From: Roger Pau Monné Date: Wed, 15 Sep 2021 09:02:21 +0000 (+0200) Subject: x86: quote section names when defining them in linker script X-Git-Tag: archive/raspbian/4.16.0+51-g0941d6cb-1+rpi1~2^2~42^2~193 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success/%22http:/www.example.com/cgi/success?a=commitdiff_plain;h=6254920587c33bcc7ab884e6c9a11cfc0d5867ab;p=xen.git x86: quote section names when defining them in linker script LLVM ld seems to require section names to be quoted at both definition and when referencing them for a match to happen, or else we get the following errors: ld: error: xen.lds:45: undefined section ".text" ld: error: xen.lds:69: undefined section ".rodata" ld: error: xen.lds:104: undefined section ".note.gnu.build-id" [...] The original fix for GNU ld 2.37 only quoted the section name when referencing it in the ADDR function. Fix by also quoting the section names when declaring them. Fixes: 58ad654ebce7 ("x86: work around build issue with GNU ld 2.37") Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S index 955d5cf4a0..11b1da2154 100644 --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -18,7 +18,7 @@ ENTRY(efi_start) #else /* !EFI */ #define FORMAT "elf64-x86-64" -#define DECL_SECTION(x) x : AT(ADDR(#x) - __XEN_VIRT_START) +#define DECL_SECTION(x) #x : AT(ADDR(#x) - __XEN_VIRT_START) ENTRY(start_pa)